Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: may exceed max tnx in etcd operations #36773

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Oct 11, 2024

issue: #36772
pr: #36775

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 11, 2024
@jaime0815 jaime0815 changed the title fix: may exceeding max tnx in etcd operations fix: may exceed max tnx in etcd operations Oct 11, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 11, 2024
Copy link
Contributor

mergify bot commented Oct 11, 2024

@jaime0815 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Oct 11, 2024
Copy link
Contributor

mergify bot commented Oct 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815 jaime0815 added this to the 2.4.13 milestone Oct 11, 2024
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (e5a6c5b) to head (cb0c945).
Report is 41 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36773      +/-   ##
==========================================
- Coverage   71.91%   71.90%   -0.02%     
==========================================
  Files        1064     1064              
  Lines      140331   140809     +478     
==========================================
+ Hits       100925   101247     +322     
- Misses      35089    35236     +147     
- Partials     4317     4326       +9     
Files with missing lines Coverage Δ
internal/metastore/kv/rootcoord/suffix_snapshot.go 82.31% <100.00%> (ø)

... and 117 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4110f35 into milvus-io:2.4 Oct 11, 2024
14 of 15 checks passed
@jaime0815 jaime0815 deleted the fix-exceed-max-tnx-24 branch October 11, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants